Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: engine_page: set password when no address is used
......................................................................

engine_page: set password when no address is used

We should allow users to set password even when no
registration is required.

Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096074
Signed-off-by: Douglas Schilling Landgraf <dougsl...@redhat.com>
---
M src/engine_page.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node-plugin-vdsm 
refs/changes/04/27604/1

diff --git a/src/engine_page.py b/src/engine_page.py
index 8f1274c..2922267 100644
--- a/src/engine_page.py
+++ b/src/engine_page.py
@@ -181,7 +181,8 @@
             )
         )
 
-        if ssl_port and effective_changes.contains_any(["action.register"]):
+        if cfg_server and ssl_port and \
+                effective_changes.contains_any(["action.register"]):
             title_msg = "\n"
             try:
                 port = findPort(cfg_server, cfg_port)
@@ -232,14 +233,14 @@
             self._fp_dialog.close()
             self._server, self._port, self._cert_path = None, None, None
 
+        if changes.contains_any(["vdsm_cfg.password"]):
+            txs += [SetRootPassword(
+                password=effective_model["vdsm_cfg.password"]
+            )]
+
         if effective_changes.contains_any(["action.register"]) and \
                 effective_model["vdsm_cfg.address"] != "":
             self.logger.debug("Connecting to engine")
-
-            if changes.contains_any(["vdsm_cfg.password"]):
-                txs += [SetRootPassword(
-                    password=effective_model["vdsm_cfg.password"])
-                ]
 
             try:
                 effective_model["vdsm_cfg.port"] = findPort(cfg_server,


-- 
To view, visit http://gerrit.ovirt.org/27604
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d2f27901fd01a8ebd1926ac7328b5cf04ea88aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to