Maor Lipchuk has posted comments on this change.
Change subject: core: Change "VM is locked" message to contain disk name
(819291)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 453:
messages.add(org.ovirt.engine.core.utils.StringUtils.createCanDoParamString("diskAlias",
Please use StringUtils without the package prefix.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/StringUtils.java
Line 196: public static String createCanDoParamString(String paramName,
String paramValue) {
Since it is a new method which is util, please add java doc comments, and tests
for it.
Suggestion: Maybe simple short method name can be more user friendly.
Maybe something like getMessageParam.
--
To view, visit http://gerrit.ovirt.org/4945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I574c3544c9a1977832dcd4365b6ea336a3a3ceff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
