Livnat Peer has posted comments on this change. Change subject: core: Added test for network boot protocol DHCP ......................................................................
Patch Set 3: Looks good to me, approved (1 inline comment) please note the style related comment in-line .................................................... File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java Line 150: String bondOptions, why add two parameters in the same line? the other parameters are single per line -- To view, visit http://gerrit.ovirt.org/5089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I743213efa4e746c5c37366eac807e4ed0072df7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
