Alexander Wels has posted comments on this change. Change subject: webadmin: fixed Coverity Scan errors ......................................................................
Patch Set 1: -Code-Review (4 comments) http://gerrit.ovirt.org/#/c/27450/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 1319: // TODO should be handled by the core framework Line 1320: object.getPropertyChangedEvent().addListener(new IEventListener() { Line 1321: @Override Line 1322: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 1323: if (args == null || !(args instanceof PropertyChangedEventArgs)) { You really don't need the null check here, if args is null it won't be a PropertyChangedEventArgs Line 1324: return; Line 1325: } Line 1326: Line 1327: String propName = ((PropertyChangedEventArgs) args).propertyName; Line 1383: object.getUsbPolicy().getPropertyChangedEvent().addListener(new IEventListener() { Line 1384: Line 1385: @Override Line 1386: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 1387: if (args == null || !(args instanceof PropertyChangedEventArgs)) { You really don't need the null check here, if args is null it won't be a PropertyChangedEventArgs Line 1388: return; Line 1389: } Line 1390: Line 1391: PropertyChangedEventArgs e = (PropertyChangedEventArgs) args; Line 1411: Line 1412: object.getCpuSharesAmountSelection().getPropertyChangedEvent().addListener(new IEventListener() { Line 1413: @Override Line 1414: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 1415: if (args == null || !(args instanceof PropertyChangedEventArgs)) { You really don't need the null check here, if args is null it won't be a PropertyChangedEventArgs Line 1416: return; Line 1417: } Line 1418: Line 1419: if ("IsAvailable".equals(((PropertyChangedEventArgs) args).propertyName)) { //$NON-NLS-1$ Line 1543: // TODO: Move to a more appropriate method Line 1544: vm.getPropertyChangedEvent().addListener(new IEventListener() { Line 1545: @Override Line 1546: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 1547: if (args == null || !(args instanceof PropertyChangedEventArgs)) { You really don't need the null check here, if args is null it won't be a PropertyChangedEventArgs Line 1548: return; Line 1549: } Line 1550: Line 1551: String propName = ((PropertyChangedEventArgs) args).propertyName; -- To view, visit http://gerrit.ovirt.org/27450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3a6438f23c530e637d557039131442ea3a73e3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
