Omer Frenkel has posted comments on this change. Change subject: core: call prccessHardwareCaps after GetHardwareInfo ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27539/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 557: if (returnStatus != oldStatus && returnStatus == VDSStatus.NonOperational) { Line 558: setIsSetNonOperationalExecuted(true); Line 559: } Line 560: Line 561: processHardwareCapsNeeded.set(monitoringStrategy.processHardwareCapabilitiesNeeded(oldVDS, vds)); is it ok that hardwareCaps will be called again? Line 562: Line 563: return returnStatus; Line 564: } else if (vdsBrokerCommand.getVDSReturnValue().getExceptionObject() != null) { Line 565: // if exception is VDSNetworkException then call to -- To view, visit http://gerrit.ovirt.org/27539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief9d623e4b46faa6809f9994ee78564b0955c306 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
