Ravi Nori has posted comments on this change. Change subject: engine : Modify Async_tasks table to use CommandEntity ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/26687/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java: Line 357: } Line 358: Line 359: public static void removeTaskFromDbByTaskId(Guid taskId) { Line 360: try { Line 361: if (TaskManagerUtil.callRemoveTaskFromDbByTaskId(taskId) != 0) { > shouldn't this also be a coco method? Eventually the method in coco gets called, this is being called from a static context so used TaskManagerUtil Line 362: log.infoFormat("Removed task {0} from DataBase", taskId); Line 363: } Line 364: } catch (RuntimeException e) { Line 365: log.error(String.format( http://gerrit.ovirt.org/#/c/26687/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java: Line 299: CommandBase command, Line 300: AsyncTaskCreationInfo asyncTaskCreationInfo, Line 301: VdcActionType parentCommand) { Line 302: VdcActionParametersBase parentParameters = command.getParentParameters(parentCommand); Line 303: AsyncTasks asyncTask = new AsyncTasks(parentCommand, > would you like to simply add more arguments to the CTOR instead of calling Done Line 304: AsyncTaskResultEnum.success, Line 305: AsyncTaskStatusEnum.running, Line 306: asyncTaskCreationInfo.getVdsmTaskId(), Line 307: parentParameters, http://gerrit.ovirt.org/#/c/26687/4/packaging/dbscripts/command_entities_sp.sql File packaging/dbscripts/command_entities_sp.sql: Line 102: DECLARE Line 103: v_id INTEGER; Line 104: SWV_RowCount INTEGER; Line 105: BEGIN Line 106: DELETE FROM command_entities > remove whitespace. Done Line 107: WHERE CREATED_AT < v_date and Line 108: command_id NOT IN(SELECT command_id FROM async_tasks); Line 109: END; $procedure$ Line 110: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/26687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied038b514f1285b4d46deff022beafd9dcfe5c29 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
