Ravi Nori has posted comments on this change. Change subject: engine: Introduction of command entity dao ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/26337/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCache.java: Line 12: public CommandEntity get(Guid commandId); Line 13: Line 14: public void remove(Guid commandId); Line 15: Line 16: public void put(Guid commandId, Guid parentCommandId, Guid rootCommandId, VdcActionType actionType, VdcActionParametersBase params, CommandStatus status); > I see that the comment I gave on the previous patch is addressed here. Yes but I think previous patch is misleading, so I fixed it. Line 17: Line 18: public void removeAllCommandsBeforeDate(DateTime cutoff); Line 19: Line 20: public void updateCommandStatus(Guid commandId, CommandStatus status); -- To view, visit http://gerrit.ovirt.org/26337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
