Juan Hernandez has uploaded a new change for review. Change subject: restapi: Madatory "suceeded" for step end ......................................................................
restapi: Madatory "suceeded" for step end The "suceeded" parameter is mandatory for the action to stop a job step. Change-Id: I55ccc732bce26f903275c280192ee83b225bc195 Bug-Url: https://bugzilla.redhat.com/1087916 Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/27520/1 diff --git a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml index 3d5b635..b58bdb6 100644 --- a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml +++ b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml @@ -4627,7 +4627,7 @@ body: parameterType: Action signatures: - - mandatoryArguments: {} + - mandatoryArguments: {action.succeeded: 'xs:boolean'} optionalArguments: {action.force: 'xs:boolean', action.status.state: 'xs:string', action.async: 'xs:boolean', action.grace_period.expiry: 'xs:long'} description: invoke the command to end the specified step of an external job with an optional agrument to force the operation urlparams: {} diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java index 6e57d58..7bad8e0 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java @@ -50,6 +50,7 @@ @Override public Response end(Action action) { + validateParameters(action, "succeeded"); return doAction(VdcActionType.EndExternalStep, new EndExternalStepParameters(guid, action.isSucceeded()), action); } -- To view, visit http://gerrit.ovirt.org/27520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I55ccc732bce26f903275c280192ee83b225bc195 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
