Sahina Bose has posted comments on this change. Change subject: webadmin : Introduce TimeUnitConverter ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27469/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/TimeUnitConverter.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/TimeUnitConverter.java: Line 8: import org.ovirt.engine.core.common.utils.Pair; Line 9: Line 10: public class TimeUnitConverter { Line 11: Line 12: public static enum TimeUnit { Can we not use java.util.concurrent.TimeUnit? There's also a convert function available..Wouldn't that do? Line 13: Line 14: /* Line 15: * The weights of the units here are their equivalent number of previous units Line 16: */ -- To view, visit http://gerrit.ovirt.org/27469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
