Daniel Erez has posted comments on this change. Change subject: webadmin: Add selinux state to host general subtab ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26962/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 824: } Line 825: Line 826: private SELinuxMode selinuxEnforceMode; Line 827: Line 828: public String getSelinuxEnforceMode() { This should be done using the EnumTranslator. For example, see VmGeneralModel - > updateProperties(). In addition, add the appropriate values to LocalizedEnums.java an LocalizedEnums.properties. Line 829: if (selinuxEnforceMode == null) { Line 830: // Nothing Line 831: } else if (selinuxEnforceMode.equals(SELinuxMode.DISABLED)) { Line 832: return constants.disabled(); Line 838: return constants.notAvailableLabel(); Line 839: } Line 840: Line 841: public void setSelinuxEnforceMode(SELinuxMode newMode) { Line 842: if (!selinuxEnforceMode.equals(newMode)) { 'selinuxEnforceMode != newMode' should be good enough Line 843: selinuxEnforceMode = newMode; Line 844: onPropertyChanged(new PropertyChangedEventArgs("selinuxEnforceMode")); //$NON-NLS-1$ Line 845: } Line 846: } -- To view, visit http://gerrit.ovirt.org/26962 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8067594169e46f8b09cc8b6247660da6e10de80 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
