Shubhendu Tripathi has posted comments on this change. Change subject: engine : Refactored gluster volume profile VdsCommand ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/26998/9//COMMIT_MSG Commit Message: Line 11: helps to query the glusterfs for 2 types of stats Line 12: nfs and brick profile stats Line 13: Line 14: Change-Id: I26cda9f8603e77296720f2dc062b94d5c10e7fd1 Line 15: Signed-off-by: Anmol Babu <anb...@redhat.com> Cannot see hashCode() and equals() method for the bean classes. http://gerrit.ovirt.org/#/c/26998/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java: Line 67: if(profileInfo.containsKey(BRICKS)) { Line 68: glusterVolumeProfileInfo.setBrickProfileDetails(prepareBrickProfileDetails(volume, Line 69: (Object[]) profileInfo.get(BRICKS))); Line 70: } else { Line 71: glusterVolumeProfileInfo.setNfsProfileDetails(prepareNfsProfileDetails((Object[]) profileInfo.get(NFSSERVERS))); If map does not contain bricks, does it always contain nfs servers ?? Line 72: } Line 73: } Line 74: } Line 75: -- To view, visit http://gerrit.ovirt.org/26998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26cda9f8603e77296720f2dc062b94d5c10e7fd1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
