Yevgeny Zaspitsky has posted comments on this change. Change subject: core: extract current implementation to strategy. ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26400/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerOriginal.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManagerOriginal.java: Line 95: } Line 96: } Line 97: Line 98: //to allow testing Line 99: List<VmNic> getVmNicInterfacesFromDB() { I'd prefer passing DAO through the constructor. That would allow mocking the DAO in the unit test and verify the class interaction with the DAO. Having said that, where's the test? Line 100: return DbFacade.getInstance().getVmNicDao().getAll(); Line 101: } Line 102: Line 103: private String instanceId() { -- To view, visit http://gerrit.ovirt.org/26400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75498bb68ec6dbe28650027116bf44a0797faf93 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
