Lior Vernia has posted comments on this change.

Change subject: restapi: Add CustomProperties member to HostNIC
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.ovirt.org/#/c/26725/14/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java:

Line 152:             
model.setCustomConfiguration(!entity.getNetworkImplementationDetails().isInSync());
Line 153:         }
Line 154: 
Line 155:         Map<String, String> properties = entity.getCustomProperties();
Line 156:         if (properties != null && !properties.isEmpty()) {
> please replace with entity.hasCustomProperties()
Done
Line 157:             
model.setProperties(CustomPropertiesParser.fromMap(properties));
Line 158:         }
Line 159: 
Line 160:         return model;


-- 
To view, visit http://gerrit.ovirt.org/26725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1cd53d4e3fd0d2f0d7bec7f1a480679a31c6c8f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to