Liron Ar has posted comments on this change. Change subject: core: Disallow RO LUN ISCSI disks ......................................................................
Patch Set 4: Verified+1 (2 comments) seems ok or solving the CDA issue. We still need to handle pre-existing disks, attach/update scnario and the tests in further patches (+1 for merging without the tests). http://gerrit.ovirt.org/#/c/27354/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java: Line 158: disk.setReadOnly(true); Line 159: disk.setDiskInterface(DiskInterface.VirtIO); Line 160: assertThat(validator.isReadOnlyPropertyCompatibleWithInterface(), isValid()); Line 161: Line 162: disk.setReadOnly(true); it's already set to true Line 163: disk.setDiskInterface(DiskInterface.VirtIO_SCSI); Line 164: assertThat(validator.isReadOnlyPropertyCompatibleWithInterface(), isValid()); Line 165: Line 166: disk.setReadOnly(false); Line 160: assertThat(validator.isReadOnlyPropertyCompatibleWithInterface(), isValid()); Line 161: Line 162: disk.setReadOnly(true); Line 163: disk.setDiskInterface(DiskInterface.VirtIO_SCSI); Line 164: assertThat(validator.isReadOnlyPropertyCompatibleWithInterface(), isValid()); this should fail iirc, please remove. Line 165: Line 166: disk.setReadOnly(false); Line 167: disk.setDiskInterface(DiskInterface.IDE); Line 168: assertThat(validator.isReadOnlyPropertyCompatibleWithInterface(), isValid()); -- To view, visit http://gerrit.ovirt.org/27354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id84346098d42f20c593c2682dc9ff99a3e77d534 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
