Eli Mesika has posted comments on this change. Change subject: core: Add selinux host info to VdsDynamic ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26955/5/packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql File packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql: Line 55: 'vds_group_compatibility_version', 'vds_group_virt_service', 'vds_group_gluster_service', 'host_os', 'kvm_version', 'libvirt_version', 'spice_version', 'kernel_version', Line 56: 'iscsi_initiator_name', 'transparent_hugepages_state', 'anonymous_hugepages', Line 57: 'non_operational_reason', 'recoverable', 'sshkeyfingerprint', 'count_threads_as_cores', 'cpu_threads', Line 58: 'hw_manufacturer', 'hw_product_name', 'hw_version', 'hw_serial_number', 'hw_uuid', 'hw_family', 'ssh_port', 'ssh_username', 'boot_time', Line 59: 'pm_detect_kdump', 'selinux_enforce_mode')); > I was not able to get it to work, for the following reason: This should be done in 0010_add_object_column_white_list_table.sql and not in an upgrade script Line 60: -- pm_options are missing Line 61: END; $function$ Line 62: LANGUAGE plpgsql; Line 63: SELECT * FROM __temp_add_object_column_white_list_table(); -- To view, visit http://gerrit.ovirt.org/26955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If472f68702b59280c721450d4db50dc27dc19a30 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
