Yair Zaslavsky has posted comments on this change. Change subject: core: Improve classpath building ......................................................................
Patch Set 1: (5 inline comments) Questions , and minor comments. Good work. .................................................... File packaging/fedora/engine-java.py Line 33: "commons-codec": "/usr/share/java/commons-codec-eap6/commons-codec.jar", I am in a dilemma if this this the correct partition between the jars. At DEV environmnet , commons-code should also be aliased. I think that maybe we should partition according to 3rd parties and to engine-specific/engine-generated jars, and use aliasing + path resolving the way you did. Line 168: def resolveExactJar(name, path): Do we need to resolve also resources that are not jars? Line 276: Oops, whitespace :) Line 283: logHandler.setFormatter(logFormatter) same Line 328: Same -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
