Gilad Chaplik has posted comments on this change. Change subject: core: Add the ability to consume Quota in internal commands ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/27355/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 805: else Line 806: result = false; Line 807: Line 808: return result; Line 809: } you have a bug here, should be: if (getActionType().getQuotaDependency() == VdcActionType.QuotaDependency.NONE) { return false; } if(isInternalExecution() && !getActionType().isQuotaDependentAsInternalCommand()) { return false; } return true; Line 810: Line 811: /** Line 812: * @return true if all parameters class and its inner members passed Line 813: * validation http://gerrit.ovirt.org/#/c/27355/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 350: private ActionGroup actionGroup; Line 351: private boolean isActionMonitored; Line 352: private static final HashMap<Integer, VdcActionType> mappings = new HashMap<Integer, VdcActionType>(); Line 353: private QuotaDependency quotaDependency; Line 354: private boolean isQuotaDependentAsInternalCommand = false; no need for 'is', the getter is generated with 'is' for booleans. Line 355: Line 356: static { Line 357: for (VdcActionType action : values()) { Line 358: mappings.put(action.getValue(), action); -- To view, visit http://gerrit.ovirt.org/27355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4c8074eef5607107703bcb68df441a577137b04 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
