Roy Golan has posted comments on this change. Change subject: core: present the guest cpu toplogy ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27243/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java: Line 278: Line 279: private int actualCpuTopology; Line 280: Line 281: public String getActualCpuTopology() { Line 282: if (actualCpuTopology < 0) { > when will it be < 0? isnt it better to use Integer that can be null? (like I flipped it to > 0 than show the real number non-positive number will show N/A otherwise Line 283: return ConstantsManager.getInstance().getConstants().notAvailableLabel(); Line 284: } else { Line 285: return String.valueOf(actualCpuTopology); Line 286: } -- To view, visit http://gerrit.ovirt.org/27243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aa88e18ba620980ee31a633deaa3345298300e2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
