Daniel Erez has uploaded a new change for review. Change subject: webadmin: LUNs table - prevent focus on margin click ......................................................................
webadmin: LUNs table - prevent focus on margin click AbstractSanStorageList: LUNs table tree leaf - use marginLeft instead of paddingLeft to prevent focus when clicking the margin. Change-Id: Iaca0e7a6a3600cb955add272caf5e87696ee457f Bug-Url: https://bugzilla.redhat.com/856940 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java 1 file changed, 17 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/27440/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java index c1fceef..251a8bf 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java @@ -3,6 +3,7 @@ import java.util.ArrayList; import java.util.List; +import com.google.gwt.core.client.Scheduler; import org.ovirt.engine.core.common.businessentities.LUNs; import org.ovirt.engine.ui.common.CommonApplicationConstants; import org.ovirt.engine.ui.common.CommonApplicationMessages; @@ -97,7 +98,7 @@ } } - protected void addRootNode(TreeItem rootItem, TreeItem leafItem) { + protected void addRootNode(final TreeItem rootItem, final TreeItem leafItem) { rootItem.getElement().getStyle().setBackgroundColor("#eff3ff"); //$NON-NLS-1$ rootItem.getElement().getStyle().setMarginBottom(1, Unit.PX); rootItem.getElement().getStyle().setPadding(0, Unit.PX); @@ -105,15 +106,22 @@ if (leafItem != null) { rootItem.addItem(leafItem); - leafItem.getElement().getStyle().setBackgroundColor("#ffffff"); //$NON-NLS-1$ - leafItem.getElement().getStyle().setMarginLeft(0, Unit.PX); - leafItem.getElement().getStyle().setPadding(0, Unit.PX); + // Deffer styling in order to override padding done in: + // com.google.gwt.user.client.ui.Tree -> showLeafImage + Scheduler.get().scheduleDeferred(new Scheduler.ScheduledCommand() { + @Override + public void execute() { + leafItem.getElement().getStyle().setBackgroundColor("#ffffff"); //$NON-NLS-1$ + leafItem.getElement().getStyle().setMarginLeft(20, Unit.PX); + leafItem.getElement().getStyle().setPadding(0, Unit.PX); - Boolean isLeafEmpty = (Boolean) leafItem.getUserObject(); - if (isLeafEmpty != null && isLeafEmpty.equals(Boolean.TRUE)) { - rootItem.getElement().getElementsByTagName("td").getItem(0).getStyle().setVisibility(Visibility.HIDDEN); //$NON-NLS-1$ - } - rootItem.getElement().getElementsByTagName("td").getItem(1).getStyle().setWidth(100, Unit.PCT); //$NON-NLS-1$ + Boolean isLeafEmpty = (Boolean) leafItem.getUserObject(); + if (isLeafEmpty != null && isLeafEmpty.equals(Boolean.TRUE)) { + rootItem.getElement().getElementsByTagName("td").getItem(0).getStyle().setVisibility(Visibility.HIDDEN); //$NON-NLS-1$ + } + rootItem.getElement().getElementsByTagName("td").getItem(1).getStyle().setWidth(100, Unit.PCT); //$NON-NLS-1$ + } + }); } tree.addItem(rootItem); -- To view, visit http://gerrit.ovirt.org/27440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaca0e7a6a3600cb955add272caf5e87696ee457f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
