Alon Bar-Lev has posted comments on this change. Change subject: backend: upgrade - process symbolic link files ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27395/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java: Line 56: for (OVirtNodeInfo.Entry info : OVirtNodeInfo.getInstance().get()) { Line 57: if (info.path.equals(iso.getParentFile())) { Line 58: try { Line 59: Matcher matcher = info.isoPattern.matcher( Line 60: iso.getCanonicalPath().substring(iso.getCanonicalPath().lastIndexOf("/")+1) if you need only file name.. should be: getCanonicalFile().getName() please avoid parsing. Line 61: ); Line 62: if (matcher.find()) { Line 63: String rpmLike = matcher.group(1).replaceAll("-", "."); Line 64: log.debugFormat("ISO version: {0} {1} {2}", iso, rpmLike, ovirtHostOsVersion); -- To view, visit http://gerrit.ovirt.org/27395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4084095c40848dc5573d434c1c7ca497883b280 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
