anmolbabu has posted comments on this change. Change subject: gluster-nagios-monitoring : messageOrigin url formation fixed ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27396/1/gluster-nagios-monitoring/src/js/trends.js File gluster-nagios-monitoring/src/js/trends.js: Line 163: * the pnp4nagios server. Line 164: */ Line 165: var pnp4NagiosUrl = ""; Line 166: if((!configObject.pnp4nagiosUrl) || (!configObject)) { Line 167: pnp4NagiosUrl = $location.protocol() + "://" + $location.host() + ((($location.port()) && ($location.absUrl().indexOf($location.port().toString()) > 0)) ? ":" + $location.port() : ""); > I think pnp4nagios should still work even if the port is specified explicit Done Line 168: } else { Line 169: pnp4NagiosUrl = configObject.pnp4nagiosUrl; Line 170: } Line 171: return pnp4NagiosUrl; -- To view, visit http://gerrit.ovirt.org/27396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dd11b3accc83fe4a603a930c4fcaf9c3261a271 Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
