Moti Asayag has posted comments on this change. Change subject: engine: refactoring NetworkUtils.getVlanDeviceName ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/27152/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java: Line 124: protected VdsNetworkInterface getVlanDevice(List<VdsNetworkInterface> nics, Line 125: VdsNetworkInterface baseNic, Line 126: Network network) { Line 127: for (VdsNetworkInterface n : nics) { Line 128: if ((baseNic.getName().equals(n.getBaseInterface()) && ObjectUtils.objectsEqual(n.getVlanId(), you can use Objects.equals() instead of external library Line 129: network.getVlanId())) Line 130: || StringUtils.equals(n.getNetworkName(), network.getName())) { Line 131: return n; Line 132: } -- To view, visit http://gerrit.ovirt.org/27152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ed8b14fb8e22d9681bdbc34d863c52b6d23be5 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
