Yedidyah Bar David has posted comments on this change. Change subject: WebSocketProxy on a separate host ......................................................................
Patch Set 23: (3 comments) As discussed, please change local_engine to oenginecons.CoreEnv.ENABLED and self._local_engine to self._engine_enabled. Not sure there is much point in maintaining wsp pki on the engine CA but I can live with that. Nice work! http://gerrit.ovirt.org/#/c/26898/23/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py: Line 316: Line 317: def _prepare_tran(self, content=''): Line 318: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 319: filetransaction.FileTransaction( Line 320: osetupcons.FileLocations. Please use argument keyword, we usually do Line 321: OVIRT_ENGINE_PKI_WEBSOCKET_PROXY_CERT, Line 322: mode=0o600, Line 323: owner=self.environment[osetupcons.SystemEnv.USER_ENGINE], Line 324: enforcePermissions=True, Line 329: ) Line 330: ) Line 331: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 332: filetransaction.FileTransaction( Line 333: osetupcons.FileLocations. same Line 334: OVIRT_ENGINE_PKI_WEBSOCKET_PROXY_KEY, Line 335: mode=0o600, Line 336: owner=self.environment[osetupcons.SystemEnv.USER_ENGINE], Line 337: enforcePermissions=True, Line 342: ) Line 343: ) Line 344: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 345: filetransaction.FileTransaction( Line 346: name=( like this one :-) Line 347: osetupcons.FileLocations. Line 348: OVIRT_ENGINE_WEBSOCKET_PROXY_CONFIG_SETUP Line 349: ), Line 350: content=( -- To view, visit http://gerrit.ovirt.org/26898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
