Moti Asayag has posted comments on this change. Change subject: engine: Adjust SetupNetworks to accept any vlan device name ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/26616/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 190: return; Line 191: } Line 192: Line 193: if (NetworkUtils.isVlan(nic)) { Line 194: String[] tokens = nic.getName().split("[.]", -1); i don't think the square brackets are mandatory. Line 195: if (tokens.length == 1) { Line 196: nic.setBaseInterface(nic.getName()); Line 197: return; Line 198: } Line 203: } why not use StringUtils.join(token, '.') instead ? Also, please add a space line after } -- To view, visit http://gerrit.ovirt.org/26616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08c952a7c1902d176709af7126f54ab37a0344d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
