Liran Zelkha has posted comments on this change. Change subject: core, webadmin: Add host# and vm# to cluster tab ......................................................................
Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/26980/8//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-04-22 18:04:09 +0300 Line 4: Commit: [email protected] <[email protected]> Line 5: CommitDate: 2014-04-30 11:40:18 +0300 Line 6: Line 7: core: Add host# and vm# to cluster tab > Please add "webadmin" component as well, for example: Done Line 8: Line 9: In webadmin add an ability to see the count of VMs and Hosts for Line 10: a cluster Line 11: http://gerrit.ovirt.org/#/c/26980/8/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java: Line 92: Line 93: TextColumnWithTooltip<VDSGroup> hostCountColumn = new TextColumnWithTooltip<VDSGroup>() { Line 94: @Override Line 95: public String getValue(VDSGroup object) { Line 96: if (object.getGroupHostsAndVms() == null) > Please use { } to enclose statement below for better readability. Done Line 97: return ""; Line 98: return object.getGroupHostsAndVms().getHosts() + ""; Line 99: } Line 100: }; Line 103: Line 104: TextColumnWithTooltip<VDSGroup> vmCountColumn = new TextColumnWithTooltip<VDSGroup>() { Line 105: @Override Line 106: public String getValue(VDSGroup object) { Line 107: if (object.getGroupHostsAndVms() == null) > Please use { } to enclose statement below for better readability. Done Line 108: return ""; Line 109: return object.getGroupHostsAndVms().getVms() + ""; Line 110: } Line 111: }; -- To view, visit http://gerrit.ovirt.org/26980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9935c67db2a88960cd721aec4bfd71e70c9b4f57 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
