Maor Lipchuk has posted comments on this change. Change subject: core: adding DAO support for unregistered VMs. ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/26480/3//COMMIT_MSG Commit Message: Line 7: core: adding DAO support for unregistered VMs. Line 8: Line 9: * Add new BE OvfEntityData Line 10: * Adding new table unregistered_ovf_of_entities Line 11: * Add stored procedured > s/procedured/procedures done Line 12: * Adding UnregisteredOVFDataDAO Line 13: Line 14: Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 http://gerrit.ovirt.org/#/c/26480/3/packaging/dbscripts/upgrade/03_05_0330_unregistered_ovf_of_entities.sql File packaging/dbscripts/upgrade/03_05_0330_unregistered_ovf_of_entities.sql: Line 2: ( Line 3: vm_guid UUID PRIMARY KEY, Line 4: vm_name character varying(255) NOT NULL, Line 5: entity_type character varying(32) NOT NULL, Line 6: storage_domain_id UUID, > The storage domain should exist in the DB? If so you should probably use a done Line 7: ovf_data text, Line 8: ovf_extra_data text, Line 9: os_id integer, Line 10: lowest_comp_version character varying(40) -- To view, visit http://gerrit.ovirt.org/26480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385fac757f46131ae0c0048b6cf39b78f037e852 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
