Liron Ar has posted comments on this change. Change subject: core: connect to sp when needed before "fencing" ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/27306/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java: Line 194: .RunVdsCommand(VDSCommandType.SpmStatus, Line 195: new SpmStatusVDSCommandParameters(vds.getId(), getStoragePool().getId())) Line 196: .getReturnValue(); Line 197: if (statusResult.getSpmStatus() == SpmStatus.Unknown_Pool) { Line 198: log.infoFormat("vds {0} - {1} isn't connected to the storage pool, attempting to connect in order to perform the operation", > Maybe it's better to indicate the status of the spm Status (Unknown_Pool), unknown_pool means that the host isn't connected to the pool which is what is written in the message, therefore i prefer to keep as is. Line 199: vds.getName(), Line 200: vds.getId()); Line 201: VDSError error = null; Line 202: Line 208: getStoragePool().getId(), Line 209: vds.getVdsSpmId(), Line 210: masterDomain.getId(), Line 211: getStoragePool().getmaster_domain_version())); Line 212: if (!vdsReturnValue.getSucceeded()) { > IINM an exception will always be thrown when ConnectStoragePool will fail this command has mixed behavior, exception is thrown only for some of the cases. Line 213: error = vdsReturnValue.getVdsError(); Line 214: } Line 215: } catch (VdcBLLException e) { Line 216: error = e.getVdsError(); Line 217: } Line 218: Line 219: if (error != null) { Line 220: log.infoFormat("Failed to connect host {0} to the storage pool with error code {1} (message {2}), " + Line 221: "trying using the next host (if available)", > Maybe it's worth to mention here that we will use the next host with Unknow we will use any host in status "UP", this block is executed only if that host isn't connected to the pool..we will use any host in status UP. Line 222: vds.getName(), Line 223: error.getCode(), Line 224: error.getMessage()); Line 225: continue; -- To view, visit http://gerrit.ovirt.org/27306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2770dd95a03afccd02174dadf902f443a0a66a49 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
