Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: fixed pep8 test ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27350/1/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 983 Line 984 Line 985 Line 986 Line 987 hmmm... this is not right... are you sure pep8 complains? not in my system. what the message you get? anyway... a solution should be: % ( self.environment[ oreportscons.JasperEnv.THEME ], ) always indent within blocks -- To view, visit http://gerrit.ovirt.org/27350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd0c16475e1fa0000c946be42e3c472fca94707 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
