Moti Asayag has uploaded a new change for review.

Change subject: engine: Skip empty bridge mappings
......................................................................

engine: Skip empty bridge mappings

If the user hasn't provided bridge mappings, there
is no need to pass it to ovirt host deploy.

Change-Id: Iaf2337d837ddb456f1c6bb70e2aec96394d2a2ea
Bug-Url: https://bugzilla.redhat.com/1093994
Bug-Url: https://bugzilla.redhat.com/1086789
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/27343/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
index 33a3326..cfec79d 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
@@ -182,7 +182,7 @@
                 if (provider.getType() == ProviderType.OPENSTACK_NETWORK) {
                     OpenstackNetworkProviderProperties agentProperties =
                             (OpenstackNetworkProviderProperties) 
provider.getAdditionalProperties();
-                    if (parameters.getNetworkMappings() != null) {
+                    if 
(StringUtils.isNotBlank(parameters.getNetworkMappings())) {
                         
agentProperties.getAgentConfiguration().setNetworkMappings(
                             parameters.getNetworkMappings()
                         );


-- 
To view, visit http://gerrit.ovirt.org/27343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf2337d837ddb456f1c6bb70e2aec96394d2a2ea
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to