Alona Kaplan has posted comments on this change. Change subject: engine: Adjust NetworkUtils to accept any vlan device name - phase 2 ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27153/5/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java: Line 264: assertFalse(NetworkUtils.isManagementNetwork(net)); Line 265: } Line 266: Line 267: private VdsNetworkInterface createVlan(String baseIfaceName) { Line 268: VdsNetworkInterface iface = new Vlan(); > You can use the 2 parameter Vlan ctor here, instead of setters Done Line 269: int vlanId = RandomUtils.instance().nextInt(100); Line 270: Line 271: iface.setBaseInterface(baseIfaceName); Line 272: iface.setVlanId(vlanId); Line 269: int vlanId = RandomUtils.instance().nextInt(100); Line 270: Line 271: iface.setBaseInterface(baseIfaceName); Line 272: iface.setVlanId(vlanId); Line 273: iface.setName(baseIfaceName + "." + vlanId); > You can have this logic inside the 2 parameter Vlan ctor Done in a previous patch. Line 274: return iface; Line 275: } Line 276: Line 277: private VdsNetworkInterface createNic(String ifaceName) { -- To view, visit http://gerrit.ovirt.org/27153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884ea51d4c7b47fef2b7fb2c89b4efd36701980c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
