Alona Kaplan has posted comments on this change. Change subject: engine: RemoveNetworksByLabelParametersBuilder accepts any vlan device name ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26610/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java: Line 75: VdsNetworkInterface nic = nicsByNetworkName.get(network.getName()); Line 76: if (nic != null) { Line 77: if (StringUtils.equals(nic.getName(), underlyingNic.getName())) { Line 78: underlyingNic.setNetworkName(null); Line 79: } else if (StringUtils.equals(NetworkUtils.stripVlan(nic), underlyingNic.getName())) { > Can't you use NetworkUtils.interfaceBasedOn here? Done Line 80: nicsToRemove.add(nic); Line 81: } Line 82: } Line 83: } -- To view, visit http://gerrit.ovirt.org/26610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22225ae3d971aa6072b161df0965dd663deff1e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
