Greg Padgett has posted comments on this change. Change subject: [WIP] core, db, packaging: introduce EntityTaskStrategy ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26913/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/EntityTaskStrategy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/EntityTaskStrategy.java: Line 14: Line 15: /** Line 16: * Strategy for async tasks whose status is ascertained via callbacks to the issuing command. Line 17: */ Line 18: public class EntityTaskStrategy implements AsyncTaskStrategy { > Usually I'm not picky about names either, in the past we did have EntityTas Thanks, makes sense. You're correct, the actual work to merge is handled by qemu and is tied to the VM even if it migrates, rather than being tied to the HSM. Line 19: private final AsyncTask task; Line 20: private CommandCallback command; Line 21: private static final Log log = LogFactory.getLog(EntityTaskStrategy.class); Line 22: http://gerrit.ovirt.org/#/c/26913/2/packaging/dbscripts/upgrade/03_05_0320_alter_async_tasks_for_non_spm_tasks.sql File packaging/dbscripts/upgrade/03_05_0320_alter_async_tasks_for_non_spm_tasks.sql: Line 2: select fn_db_rename_column('async_tasks', 'storage_pool_id', 'object_id'); Line 3: select fn_db_add_column('async_tasks', 'object_type', 'INTEGER'); Line 4: Line 5: -- existing values correspond to VdcObjectType.StoragePool (14) Line 6: UPDATE async_tasks SET object_type = 14 WHERE object_type IS NULL AND object_id IS NOT NULL; > just don't forget to change object_id and object_type here to something els Thanks. -- To view, visit http://gerrit.ovirt.org/26913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59392247ff2caf997030f4cf975273b3bac69c33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
