Lior Vernia has posted comments on this change.
Change subject: webadmin: Fix @SuppressWarnings("unchecked") + organize imports
......................................................................
Patch Set 1:
(1 comment)
Small comment, other then that it's good to merge.
http://gerrit.ovirt.org/#/c/27296/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java:
Line 253:
object.getBondingOptions().getSelectedItemChangedEvent().addListener(new
IEventListener() {
Line 254: @Override
Line 255: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 256: @SuppressWarnings("unchecked")
Line 257: ListModel<Map.Entry<String, EntityModel<String>>>
list = (ListModel<Map.Entry<String, EntityModel<String>>>) sender;
If you're so busy beautifying then you might as well format this huge line.
Line 258: Map.Entry<String, EntityModel<String>> pair =
list.getSelectedItem();
Line 259: if ("custom".equals(pair.getKey())) { //$NON-NLS-1$
Line 260: customEditor.setVisible(true);
Line 261: String entity = pair.getValue().getEntity();
--
To view, visit http://gerrit.ovirt.org/27296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0c9d16e1d9088fb8137506cb70e6d3ff38cd1f9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
