Maor Lipchuk has posted comments on this change. Change subject: core: introduce RemoveDiskSnapshotsCommand ......................................................................
Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26327/8/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java: Line 116: @Test Line 117: public void testDomainWithEnoughSizeToRemoveDiskSnapshotsMaxVirtualSize() { Line 118: validator = new StorageDomainValidator(mockStorageDomain(1024, 0, StorageType.NFS)); Line 119: DiskImage image1 = mockDiskImage(1024, 1024); Line 120: DiskImage image2 = mockDiskImage(256, 1024); I would also add a negetive test here when the domain has virtual size of less then 1024 Line 121: Line 122: assertTrue("Domain should have enough space for merging the snapshots", Line 123: validator.hasSpaceForRemovingDiskSnapshots(Arrays.asList(image1, image2)).isValid()); Line 124: } -- To view, visit http://gerrit.ovirt.org/26327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia714a4390d1d9b672005be30f58b7fa98b9a31cd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
