Oved Ourfali has posted comments on this change. Change subject: engine : Introduction of CallBack interface ......................................................................
Patch Set 5: Code-Review+1 (1 comment) @Ravi - minor comments. Check also other javadoc, as some are broken. @Yair - please respond to Ravi's question on your comment on his first patch set. http://gerrit.ovirt.org/#/c/26333/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java: Line 18: /** Line 19: * Constructs a task based on creation info (task type and task parameters Line 20: * as retrieved from the vdsm). Use in order to construct tasks when service Line 21: * is initializing. Line 22: * Please update the javadoc here as well. Line 23: * @param taskID Line 24: * the ID of the task to construct. Line 25: * @param pollingEnabled Line 26: * true if we want to start polling the task, false otherwise. -- To view, visit http://gerrit.ovirt.org/26333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c12315c96168fd32dc05ac6de336ccdd63c9fbc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
