Lior Vernia has posted comments on this change. Change subject: webadmin: Add network custom properties in Setup Networks ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/26650/13/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java: Line 41: asPopupPanel().setPixelSize(400, 590); Line 42: Line 43: enableDisableBySync(object); Line 44: Line 45: customPropertiesPanel.setVisible(object.getCustomPropertiesModel().getIsAvailable()); > Why isn't it part of enableDisableBySync(..)? Just because enableDisableBySync() is also called by HostInterfacePopupView, where I don't want the custom properties panel to ever show. Line 46: customPropertiesWidget.edit(object.getCustomPropertiesModel()); Line 47: } -- To view, visit http://gerrit.ovirt.org/26650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bc9f38f48fcf1bd9998228d316093db2db69782 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
