Shirly Radco has posted comments on this change. Change subject: reports: br2c report - added comments to queries ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/26486/5/packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data: Line 90: -- equals to "hourly" else "daily" Line 91: FROM v3_4_statistics_hosts_resources_usage_$P!{table_name} Line 92: WHERE Line 93: -- Here we filter by the host chosen by the user Line 94: v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_id = > Why did you change hourly to $P!{table_name} ? this will break this report. Done Line 95: CASE $P{P_Host_ID} Line 96: WHEN '00000000-0000-0000-0000-000000000000' Line 97: THEN '00000000-0000-0000-0000-000000000000' Line 98: WHEN NULL Line 388: AND v3_4_configuration_history_hosts_interfaces.host_interface_id IN ( Line 389: SELECT c.host_interface_id Line 390: FROM Line 391: v3_4_statistics_hosts_interfaces_resources_usage_$P!{table_name} b Line 392: INNER JOIN v3_4_configuration_history_hosts_interfaces c > This should be indented by one more tab moved up the first table .so the inner join is indented correctly now Line 393: ON ( c.host_interface_id = b.host_interface_id ) Line 394: WHERE c.host_id = Line 395: CASE $P{P_Host_ID} Line 396: WHEN '00000000-0000-0000-0000-000000000000' Line 391: v3_4_statistics_hosts_interfaces_resources_usage_$P!{table_name} b Line 392: INNER JOIN v3_4_configuration_history_hosts_interfaces c Line 393: ON ( c.host_interface_id = b.host_interface_id ) Line 394: WHERE c.host_id = Line 395: CASE $P{P_Host_ID} > This should be indented by one more tab Done Line 396: WHEN '00000000-0000-0000-0000-000000000000' Line 397: THEN '00000000-0000-0000-0000-000000000000' Line 398: WHEN NULL Line 399: THEN '00000000-0000-0000-0000-000000000000' -- To view, visit http://gerrit.ovirt.org/26486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82104ef88054a831cdac46ab9f67c200fb499956 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
