Yaniv Dary has posted comments on this change. Change subject: reports: br2a report - added comments to queries ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26490/4/packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data: Line 353: WHEN '11111111-1111-1111-1111-111111111111' Line 354: THEN '00000000-0000-0000-0000-000000000000' Line 355: ELSE CAST ( $P{P_Host_ID} AS uuid ) Line 356: END Line 357: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Change to single space. Line 358: AND history_datetime < Line 359: CASE Line 360: WHEN $P{P_Period} = 0 Line 361: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 407: AVG ( Line 408: COALESCE ( b.transmit_rate_percent, 0 ) Line 409: ) DESC Line 410: LIMIT 5 Line 411: ) tailing whitespace Line 412: -- Here we get or remove deleted entities according to what the user chose Line 413: -- in the "is_deleted" parameter. Line 414: $P!{is_deleted} Line 415: GROUP BY -- To view, visit http://gerrit.ovirt.org/26490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19031f7037833deae9a232f054d887ba5e946410 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
