Yaniv Dary has posted comments on this change. Change subject: reports: br2b report - added comments to queries ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26450/6/packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data: Line 118: RIGHT OUTER JOIN calendar Line 119: ON ( $P!{calendar_column} = time ) Line 120: WHERE $P!{calendar_column} >= CAST ( $P{P_Start_Date} AS date ) Line 121: AND $P!{calendar_column} < Line 122: CASE This should be indented by one less tab Line 123: WHEN $P{P_Period} = 0 Line 124: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 125: WHEN $P{P_Period} = 1 Line 126: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 month' -- To view, visit http://gerrit.ovirt.org/26450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibccaba25b0ffefd7d24fd8b446bb1f74caff9296 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
