Yaniv Dary has posted comments on this change.

Change subject: reports: br6 report - added comments to queries
......................................................................


Patch Set 14:

(3 comments)

http://gerrit.ovirt.org/#/c/25227/14/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/cluster_quality_of_service_hosts_br6_jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Service_level/Hosts/cluster_quality_of_service_hosts_br6_files/cluster_quality_of_service_hosts_br6_jrxml.data:

Line 318:     (
Line 319:         CASE
Line 320:             WHEN
Line 321:                     time_above_mem_threshold = 0
Line 322:                     AND time_above_cpu_threshold = 0
should be indented by one less tab
Line 323:                 THEN 1 -- Memory and cpu are below the threshold
Line 324:             ELSE 0 -- Memory and / or cpu are above threshold
Line 325:         END
Line 326:     ) ASC,


Line 329:     -- where above the threshold out of the overall host time.
Line 330:     (
Line 331:         CAST ( t.time_above_cpu_threshold AS float ) /
Line 332:         CAST ( t.overall_host_time AS float )
Line 333:     ) *100 +
space after *
Line 334:     (
Line 335:         CAST ( t.time_above_mem_threshold AS float ) /
Line 336:         CAST ( t.overall_host_time AS float )
Line 337:     ) *100 DESC]]>


Line 333:     ) *100 +
Line 334:     (
Line 335:         CAST ( t.time_above_mem_threshold AS float ) /
Line 336:         CAST ( t.overall_host_time AS float )
Line 337:     ) *100 DESC]]>
space after *
Line 338:       </queryString>
Line 339:       <field name="cluster_id" class="java.lang.Object"/>
Line 340:       <field name="host_id" class="java.lang.Object"/>
Line 341:       <field name="host_name" class="java.lang.String"/>


-- 
To view, visit http://gerrit.ovirt.org/25227
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c7f8127ad7fca24446776427b2eb6bce843b1cb
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to