Martin Peřina has posted comments on this change. Change subject: core: Add config values for host kdump detection ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27199/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 682: select fn_db_add_config_value('NextKdumpTimeout','60','general'); Line 683: select fn_db_add_config_value('FenceKdumpMessageInterval','5','general'); Line 684: select fn_db_add_config_value('FenceKdumpListenerHost','','general'); Line 685: select fn_db_add_config_value('FenceKdumpListenerPort','7410','general'); Line 686: select fn_db_add_config_value('FenceKdumpListenerAliveTimeout','10','general'); > Just to make sure, all of those value are not exposed to engine-config ??? Yes, I don't want them to be changed by engine-config, because improper changes could make whole process unusable. Only FenceKdumpListenerHost and FenceKdumpListenerPort can be set during engine-setup (this will be added in following patches), because if those 2 values will be changed all hosts should be redeployed. Line 687: Line 688: ------------------------------------------------------------------------------------ Line 689: -- Update with override section Line 690: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/27199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451719415958b21aa421105f4154db4afc755c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
