Yedidyah Bar David has posted comments on this change. Change subject: WebSocketProxy on a separate host ......................................................................
Patch Set 10: (6 comments) http://gerrit.ovirt.org/#/c/26898/10/packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py File packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py: Line 67: # TODO: ask if user is really going to install the engine as Line 68: # Didi proposed Line 69: self.environment[ Line 70: osetupcons.CoreEnv.ENGINE_LOCAL Line 71: ] = True You should probably setdefault to None in common during stage_boot or something like that. Line 72: Line 73: http://gerrit.ovirt.org/#/c/26898/10/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py: Line 17 Line 18 Line 19 Line 20 Line 21 we usually keep two blank lines here Line 21 Line 22 Line 23 Line 24 Line 25 same Line 70 Line 71 Line 72 Line 73 Line 74 Please address this - adapt code if needed and edit the comment. Line 67: self.environment[ Line 68: osetupcons.CoreEnv.ENGINE_LOCAL Line 69: ] is not None and self.environment[ Line 70: osetupcons.CoreEnv.ENGINE_LOCAL Line 71: ] Not sure what you check here, perhaps you meant: if osetupcons.CoreEnv.ENGINE_LOCAL in self.environment and ... you can also: self._local_engine = self.environment.get(osetupcons.CoreEnv.ENGINE_LOCAL, False) But better to just setdefault to None early, and here: self._local_engine = self.environment[osetupcons.CoreEnv.ENGINE_LOCAL] Line 72: ): Line 73: self._local_engine = True Line 74: else: Line 75: self._local_engine = False Line 409: 'the engine host' Line 410: ) Line 411: ) Line 412: self._fetch_certs() Line 413: # FIX: I've to ensure also that proxy cert it's relative to my host So scp is mandatory? I think we should at least let the user copy them manually and see that they are in place and use them, probably with some more text in the error above saying what was/wasn't found or something like that. Line 414: Line 415: if self._local_wsp: Line 416: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 417: filetransaction.FileTransaction( -- To view, visit http://gerrit.ovirt.org/26898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169604429e5a2d72573b05c0e5481306edfdd935 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
