Mike Kolesnik has posted comments on this change. Change subject: engine: adding base_interface column to vds_interface table ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/26605/6/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 4537: <null /> Line 4538: <null /> Line 4539: <null /> Line 4540: <null /> Line 4541: <null /> There should be some value here, since vlan id is 1000 Line 4542: <value>1000</value> Line 4543: <value>10.35.110.13</value> Line 4544: <value>255.255.255.0</value> Line 4545: <null /> Line 4559: <null /> Line 4560: <null /> Line 4561: <null /> Line 4562: <null /> Line 4563: <null /> There should be some value here, since vlan id is 1000 Line 4564: <value>1000</value> Line 4565: <value>10.35.110.11</value> Line 4566: <value>255.255.255.0</value> Line 4567: <null /> Line 4581: <null /> Line 4582: <null /> Line 4583: <null /> Line 4584: <null /> Line 4585: <null /> There should be some value here, since vlan id is 1000 Line 4586: <value>1000</value> Line 4587: <value>10.35.110.12</value> Line 4588: <value>255.255.255.0</value> Line 4589: <null /> http://gerrit.ovirt.org/#/c/26605/6/packaging/dbscripts/upgrade/03_05_0340_add_base_interface_column_to_vds_interfaces.sql File packaging/dbscripts/upgrade/03_05_0340_add_base_interface_column_to_vds_interfaces.sql: Line 1: select fn_db_add_column('vds_interface', 'base_interface', 'varchar(50)'); Line 2: update vds_interface set base_interface = substring(name from '(.*)\.[^\.]*'); Perhaps worth checking if vlan_id is not null? -- To view, visit http://gerrit.ovirt.org/26605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87ac5121b9e7d3b74f5557336e5d504ef91b7702 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
