Moti Asayag has posted comments on this change. Change subject: engine: Enable subscribing to change display network warnings. ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27214/2/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java: Line 927: Line 928: String KdumpStatus___DISABLED(); Line 929: Line 930: String KdumpStatus___ENABLED(); Line 931: checkstyle probably informed you that whitespaces break the build. Line 932: String AuditLogType__NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM(); Line 933: Line 934: String AuditLogType__NETWORK_UPDATE_DISPLAY_FOR_HOST_WITH_ACTIVE_VM(); Line 935: http://gerrit.ovirt.org/#/c/27214/2/packaging/dbscripts/upgrade/03_05_0350_add_display_network_change_events.sql File packaging/dbscripts/upgrade/03_05_0350_add_display_network_change_events.sql: Line 1: delete from event_map Line 2: where event_up_name in ( Line 3: 'NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM', please remove white spaces. Line 4: 'NETWORK_UPDATE_DISPLAY_FOR_HOST_WITH_ACTIVE_VM'); Line 5: Line 6: insert into event_map(event_up_name, event_down_name) Line 7: values('NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM', 'UNASSIGNED'); -- To view, visit http://gerrit.ovirt.org/27214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0ac48a6fffc7b0cfa4c971f9e038b2b696c0e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
