Moti Asayag has posted comments on this change. Change subject: engine: Audit log warning about display network connectivity change. (CollectVdsNetworkDataVDSCommand) ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/27168/7/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 518: the s/after the next reboot/after their next reboot appear http://gerrit.ovirt.org/#/c/27168/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java: Line 184: } Line 185: } Line 186: Line 187: private static boolean isVmRunningOnHost(Guid hostId) { Line 188: return !DbFacade.getInstance().getVmDao().getAllRunningForVds(hostId).isEmpty(); replacing with VmDynamicDAO.getAllRunningForVds(id) will save couple of bits and db cpu. Line 189: } Line 190: Line 191: private static Collection<Network> findNetworksOnInterfaces( Line 192: Collection<VdsNetworkInterface> ifaces, -- To view, visit http://gerrit.ovirt.org/27168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9949fc6ed52871ccfb1a15397e2cc722ad231b8f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
