Tal Nisan has uploaded a new change for review. Change subject: coverity: Fix FB.SIC_INNER_SHOULD_BE_STATIC errors in ClusterManageNetworkPopupView ......................................................................
coverity: Fix FB.SIC_INNER_SHOULD_BE_STATIC errors in ClusterManageNetworkPopupView Change-Id: I52b5b1f5d0912fb043fb811421d6eff1be437aa8 Signed-off-by: Tal Nisan <tni...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/27206/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java index 380eaaf..31534f2 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java @@ -135,7 +135,7 @@ && !clusterNetworkModel.isExternal(); } - private final class NetworkNameTextColumnWithTooltip extends TextColumnWithTooltip<ClusterNetworkModel> { + private static final class NetworkNameTextColumnWithTooltip extends TextColumnWithTooltip<ClusterNetworkModel> { @Override public String getValue(ClusterNetworkModel clusterNetworkModel) { return clusterNetworkModel.getDisplayedName(); @@ -301,7 +301,7 @@ } } - private final class MigrationNetworkIndicatorCheckboxColumn extends CheckboxColumn<ClusterNetworkModel> { + private static final class MigrationNetworkIndicatorCheckboxColumn extends CheckboxColumn<ClusterNetworkModel> { private MigrationNetworkIndicatorCheckboxColumn(boolean multipleSelectionAllowed, MigrationNetworkIndicatorFieldUpdater migrationNetworkIndicatorFieldUpdater) { super(multipleSelectionAllowed, migrationNetworkIndicatorFieldUpdater); @@ -338,7 +338,7 @@ } } - private final class DisplayNetworkIndicatorCheckboxColumn extends CheckboxColumn<ClusterNetworkModel> { + private final static class DisplayNetworkIndicatorCheckboxColumn extends CheckboxColumn<ClusterNetworkModel> { private DisplayNetworkIndicatorCheckboxColumn(boolean multipleSelectionAllowed, DisplayNetworkIndicatorFieldUpdater displayNetworkIndicatorFieldUpdater) { super(multipleSelectionAllowed, displayNetworkIndicatorFieldUpdater); -- To view, visit http://gerrit.ovirt.org/27206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52b5b1f5d0912fb043fb811421d6eff1be437aa8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches