Roy Golan has posted comments on this change. Change subject: core: Batch updates might create a database deadlock ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27173/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java: Line 59: Collections.sort(sortedParamValues, new Comparator<T>() { Line 60: Line 61: @Override Line 62: public int compare(T o1, T o2) { Line 63: if (o1 instanceof Comparable) { null values in the collection are possible? Line 64: return ((Comparable)o1).compareTo(o2); Line 65: } else if (o1.getId() instanceof Comparable) { Line 66: return ((Comparable)o1.getId()).compareTo(o2.getId()); Line 67: } -- To view, visit http://gerrit.ovirt.org/27173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
