Moti Asayag has posted comments on this change. Change subject: core: VdsNetworkInterface to support empty properties map ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27116/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java: Line 126: .addValue("vlan_id", nic.getVlanId()) Line 127: .addValue("mtu", nic.getMtu()) Line 128: .addValue("bridged", nic.isBridged()) Line 129: .addValue("qos_overridden", nic.isQosOverridden()) Line 130: .addValue("labels", SerializationFactory.getSerializer().serialize(nic.getLabels())) the other way around: .addValue("custom_properties", nic.hasCustomProperties() ? SerializationFactory.getSerializer().serialize(nic.getCustomProperties() : null); Line 131: .addValue("custom_properties", Line 132: SerializationFactory.getSerializer() Line 133: .serialize(nic.hasCustomProperties() ? nic.getCustomProperties() : null)); Line 134: } -- To view, visit http://gerrit.ovirt.org/27116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1cad7133800b4b8c2b7eb7e8be0be80a1e5cb9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches