Lior Vernia has posted comments on this change. Change subject: webadmin: Provide confirmation prompt while unplugging a Vnic ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Note small comment. http://gerrit.ovirt.org/#/c/27198/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java: Line 171: } Line 172: Line 173: @Override Line 174: public void executeCommand(UICommand command) Line 175: { Consider moving the opening brackets here and below to a previous line - I'm not a stickler on conventions, but that seems to be the standard in the project. Line 176: if (ON_SAVE_COMMAND.equals(command.getName())) Line 177: { Line 178: confirmSave(); Line 179: } -- To view, visit http://gerrit.ovirt.org/27198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf1c384f0205bb8b30cda038963eb49eba1dae55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
