Yaniv Dary has posted comments on this change. Change subject: history: updated etl process for scalablility ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/26952/17/packaging/dbscripts/upgrade/03_04_0090_add_HourlyAggFailed.sql File packaging/dbscripts/upgrade/03_04_0090_add_HourlyAggFailed.sql: Line 1: -- Add a flag to history_configuration when hourly aggregation failes Line 2: INSERT INTO history_configuration ( var_name, var_value) Line 3: VALUES ( 'HourlyAggFailed', 'false') needs to be: SELECT 'HourlyAggFailed', 'false' You didn't verify the create db. Line 4: WHERE not exists (SELECT var_name Line 5: FROM history_configuration -- To view, visit http://gerrit.ovirt.org/26952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7e6f8ad7238456a1e9cd05396cce217fa02a39 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
